From 4f5d3f13718db77522d9d4bdaa6220eb79829459 Mon Sep 17 00:00:00 2001 From: Ryan Schmidt Date: Mon, 25 Jun 2018 13:39:48 -0700 Subject: [PATCH] Style changes - Turns out we use OR elsewhere in expression context (even though it's technically an undocumented behavior), so use it here as well for consistency - Change indents to match other SQL statement indentation - Change join condition ordering to put the joined table first (personal nit I enjoy picking) --- src/db.py | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/db.py b/src/db.py index 7b07656..c9175fb 100644 --- a/src/db.py +++ b/src/db.py @@ -352,13 +352,13 @@ def get_player_totals(acc, hostmask): totals = [] for row in c: tmp[row[0]] = row[1] - c.execute("""SELECT SUM(gp.team_win | gp.indiv_win) - FROM game_player gp - JOIN player pl - ON gp.player = pl.id - JOIN person pe - ON pl.person = pe.id - WHERE pe.id = ?""", (peid,)) + c.execute("""SELECT SUM(gp.team_win OR gp.indiv_win) + FROM game_player gp + JOIN player pl + ON pl.id = gp.player + JOIN person pe + ON pe.id = pl.person + WHERE pe.id = ?""", (peid,)) won_games = c.fetchone()[0] order = role_order() name = _get_display_name(peid)