notnull/mwe-comments
1
0
Fork 1
Code Issues Pull Requests 1 Releases Wiki Activity

fix toggling and thread view #2

Merged
notnull merged 1 commits from tsr/mwe-comments:recursion into recursion 2019-07-13 09:27:23 -04:00
Conversation 2 Commits 1 Files Changed 6 +62 -54
tsr commented 2019-07-13 08:17:57 -04:00
Contributor
Copy Link
  • pass all comments to ThreadList
  • filter comments based on threadLevel === parentId
  • pass comment id to toggleCollapse()
- pass all comments to ThreadList - filter comments based on threadLevel === parentId - pass comment id to toggleCollapse()
tsr commented 2019-07-13 08:18:19 -04:00
Author
Contributor
Copy Link

closed dupe #1

closed dupe #1
tsr closed this pull request 2019-07-13 08:18:19 -04:00
tsr reopened this pull request 2019-07-13 08:19:00 -04:00
notnull closed this pull request 2019-07-13 09:27:22 -04:00
notnull commented 2019-07-13 09:46:10 -04:00
Owner
Copy Link

Potential issues:

  • the 'collapsed' property is added to comment but before this happens, comment does not have a property 'collapsed'

    • we could store this ifo in the db later, like what threads a user hid in the past

  • what this currently does is hides all of the comments that are collapsed, while what I imagined is it would show nested collapsed versions of the comments

  • we can have two different functions: 'hide' thread which does what it does now and 'collapse' which shows nested collapsed comments

Potential issues: - the 'collapsed' property is added to comment but before this happens, comment does *not* have a property 'collapsed' - we could store this ifo in the db later, like what threads a user hid in the past - what this currently does is hides all of the comments that are collapsed, while what I imagined is it would show nested collapsed versions of the comments - we can have two different functions: 'hide' thread which does what it does now and 'collapse' which shows nested collapsed comments
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: notnull/mwe-comments#2
No description provided.
Delete Branch "tsr/mwe-comments:recursion"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?