From c88afaacb06cf477c68100018e3e730318558522 Mon Sep 17 00:00:00 2001 From: Sam Ruby Date: Fri, 11 Feb 2011 12:01:02 -0500 Subject: [PATCH] Case insensitive rel values; ensure linked icon exists --- favicon.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/favicon.py b/favicon.py index ad9f5d2..2e351a3 100644 --- a/favicon.py +++ b/favicon.py @@ -32,11 +32,11 @@ for sub in config.subscriptions(): def favicon(page): parser=html5parser.HTMLParser(tree=treebuilders.getTreeBuilder('dom')) doc=parser.parse(urlopen(page)) + favicon = urljoin(page, '/favicon.ico') for link in doc.getElementsByTagName('link'): if link.hasAttribute('rel') and link.hasAttribute('href'): - if 'icon' in link.attributes['rel'].value.split(' '): - return urljoin(page, link.attributes['href'].value) - favicon = urljoin(page, '/favicon.ico') + if 'icon' in link.attributes['rel'].value.lower().split(' '): + favicon = urljoin(page, link.attributes['href'].value) if urlopen(favicon).info()['content-length'] != '0': return favicon