notnull/mwe-comments
1
0
Fork 1
Code Issues Pull Requests 1 Releases Wiki Activity

show nested collapsed comments #3

New Issue
Closed
opened 2019-07-13 11:08:20 -04:00 by tsr · 1 comment
tsr commented 2019-07-13 11:08:20 -04:00
Contributor
Copy Link

the merged commit in #2 hides all collapsed comments, while notnull imagined to show nested collapsed versions of the comments like on lj

we can have two different functions: 'hide' thread which does what it does now and 'collapse' which shows nested collapsed comments

  • on lj expand/collapse only affects replies, not the comment itself
  • problem: recursively toggling a thread with hidden replies would unhide them. solution: pass intended state
the merged commit in #2 hides all collapsed comments, while notnull imagined to show nested collapsed versions of the comments like on lj we can have two different functions: 'hide' thread which does what it does now and 'collapse' which shows nested collapsed comments - on lj expand/collapse only affects replies, not the comment itself - problem: recursively toggling a thread with hidden replies would unhide them. solution: pass intended state
tsr commented 2019-07-14 07:01:25 -04:00
Author
Contributor
Copy Link

#4 got merged

#4 got merged
tsr closed this issue 2019-07-14 07:01:25 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: notnull/mwe-comments#3
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?