This reverts commit f49e7371b877c2eadf1dd720084f1cee374922ad.
Thinking about it, the old behavior actually makes sense. X visits Y,
and Y visits X. When wolf targets X, they find Y, and vice versa.
At 12 players, there are two harlots, and they can visit each other.
This is intended to make both of them invincible, but the actual
behavior was that the one visiting the victim would die.
chk_nightdone used to check whether the number of people seen equals
the number of seers (and the same for harlot, etc.). This means night
times out if the seer (etc.) leaves after seeing but before night is
otherwise ended. This commit changes equals to >=, and swaps around the
wolf part of that condition so that it matches the other parts.
This commit moves the !votes and !stats rate limit warnings to user
notices intead of in-channel messages, to be consistent with the other
rate limit warnings and because those messages are usually just
pointless noise. It also moves the CARE_BOLD and CARE_COLOR messages
to user notices, because they're spammy and annoying and just make
things worse when they're in-channel.
Instead of setting make_stasis as soon as they leave, then setting it
again with a negative number if they rejoin, we can just set it when
they actually reach the timer and are killed. We were actually doing
*both* up to now (which was probably what was causing the double stasis
mentioned in issue #8), so I just removed the make_stasis calls when
people leave and come back, and kept the one when they get killed.
Per discussion in #wolfgame-dev, this commit changes the playercounts at
which drunk, traitor, and wolf2 are introduced. It removes drunk from 6p
and 7p games (moving it from 6 to 8), adds traitor to 8p and 9p games
(moving it from 10 to 8), and removes wolf2 from 8p and 9p games (moving
it from 8 to 10).
Or, in other words, it moves drunk later and switches traitor and wolf2.
Statistics on the effect of these two changes can be measured
independently, because they affect different ranges of games.
If this commit causes gameplay or other issues, feel free to revert it.
The message about wolves winning was unclear that the comparison is
between wolves and uninjured villagers, which caused confusion a few
times because people thought the game ended due to a bug. This commit
changes the message to avoid this confusion.
Minor change requested by someone in #wolfgame a while ago. The old
!retract message ended in a period, and it's still there in the logger
message, but the new in-channel message didn't have one.
